[SYCL][UR] Add dynamic linking and program flags #20272
Open
+1,009
−111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds two new experimental parts:
1. A new UR function `urProgramDynamicLinkExp` for dynamically linking
binaries in built programs. Support for this can be checked by
querying `UR_DEVICE_INFO_DYNAMIC_LINK_SUPPORT_EXP`.
2. A new flag enum `ur_exp_program_flags_t` used by
exp-multi-device-compile functions. This enum currently only has a
single flag `UR_EXP_PROGRAM_FLAG_ALLOW_UNRESOLVED_SYMBOLS` which
instructs the `urProgramLinkExp` function that unresolved external
symbols should be allowed after linking.
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
reviewed
Oct 2, 2025
| pDdiTable->pfnBuildExp = urProgramBuildExp; | ||
| pDdiTable->pfnCompileExp = nullptr; | ||
| pDdiTable->pfnLinkExp = nullptr; | ||
| pDdiTable->pfnDynamicLinkExp = nullptr; |
There was a problem hiding this comment.
Should the offload adapter not provide a value for UR_DEVICE_INFO_DYNAMIC_LINK_SUPPORT_EXP as well?
There was a problem hiding this comment.
Good eye! I totally missed this. Most likely because I grepped for UR_DEVICE_INFO_MULTI_DEVICE_COMPILE_SUPPORT_EXP which isn't covered by the offload adapter currently. Neither is UR_DEVICE_INFO_USM_P2P_SUPPORT_EXP I've noticed.
RossBrunton
reviewed
Oct 2, 2025
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
changed the title
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
bratpiorka
approved these changes
Oct 3, 2025
pbalcer
approved these changes
Oct 10, 2025
Comment on lines
+586
to
+589
| for (uint32_t I = 0; I < count; ++I) | ||
| if (phPrograms[I]->hasZeModuleForDevice(Device->ZeDevice)) | ||
| ZeModules.push_back( | ||
| phPrograms[I]->getZeModuleHandle(Device->ZeDevice)); |
There was a problem hiding this comment.
nit: please add {}. I found this difficult to parse.
Comment on lines
+594
to
+595
| // TODO: What should be done with the log? Since there is no result | ||
| // program, what can it be attached to? |
There was a problem hiding this comment.
We should probably revisit this design with build log being returned by an info query. Instead we should do what L0 does, and just return the log as an optional output parameter.
For now, just leave the TODO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds two new experimental parts:
urProgramDynamicLinkExpfor dynamically linking binaries in built programs. Support for this can be checked by queryingUR_DEVICE_INFO_DYNAMIC_LINK_SUPPORT_EXP.ur_exp_program_flags_tused by exp-multi-device-compile functions. This enum currently only has a single flagUR_EXP_PROGRAM_FLAG_ALLOW_UNRESOLVED_SYMBOLSwhich instructs theurProgramLinkExpfunction that unresolved external symbols should be allowed after linking.